Skip to content

🛡️ Sentinel: [CRITICAL/HIGH] Fix Unsafe Deserializers Missing in Taint Tracking - #171

Open
tachyon-beep wants to merge 2 commits into
mainfrom
sentinel-fix-deserialization-sinks-3316159959976357791
Open

🛡️ Sentinel: [CRITICAL/HIGH] Fix Unsafe Deserializers Missing in Taint Tracking#171
tachyon-beep wants to merge 2 commits into
mainfrom
sentinel-fix-deserialization-sinks-3316159959976357791

Conversation

@tachyon-beep

Copy link
Copy Markdown
Collaborator

🚨 Severity: HIGH
đź’ˇ Vulnerability: Curated third-party deserialization sinks (dill.load, dill.loads, jsonpickle.decode, joblib.load) were missing from _SERIALISATION_SINKS in taint tracking, allowing validation provenance to persist on untrusted payloads.
🎯 Impact: Untrusted data flowing into these dangerous deserialization functions might not be properly tracked as UNKNOWN_RAW, leading to false negatives in security scanning.
đź”§ Fix: Added the missing unconditional third-party deserializers to the core _SERIALISATION_SINKS mapping. Conditionally unsafe sinks (numpy.load, torch.load) were intentionally omitted.
âś… Verification: Run make test and make scan-self. Golden identity tests regenerated.


PR created automatically by Jules for task 3316159959976357791 started by @tachyon-beep

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

đź‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a đź‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI lite review requested due to automatic review settings August 28, 2026 16:39
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing third‑party deserialization sinks to Wardline’s Level 2 taint tracking so calls to these APIs drop validation provenance and produce UNKNOWN_RAW, preventing false negatives in downstream security rules.

Changes:

  • Extend _SERIALISATION_SINKS to include dill.load, dill.loads, jsonpickle.decode, and joblib.load.
  • Ensure these sinks participate in the existing “serialisation sink ⇒ UNKNOWN_RAW” behavior (including alias-closure via call taint maps).

đź’ˇ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants