🛡️ Sentinel: [CRITICAL/HIGH] Fix Unsafe Deserializers Missing in Taint Tracking - #171
🛡️ Sentinel: [CRITICAL/HIGH] Fix Unsafe Deserializers Missing in Taint Tracking#171tachyon-beep wants to merge 2 commits into
Conversation
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
đź‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a đź‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Adds missing third‑party deserialization sinks to Wardline’s Level 2 taint tracking so calls to these APIs drop validation provenance and produce UNKNOWN_RAW, preventing false negatives in downstream security rules.
Changes:
- Extend
_SERIALISATION_SINKSto includedill.load,dill.loads,jsonpickle.decode, andjoblib.load. - Ensure these sinks participate in the existing “serialisation sink ⇒
UNKNOWN_RAW” behavior (including alias-closure via call taint maps).
đź’ˇ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
🚨 Severity: HIGH
đź’ˇ Vulnerability: Curated third-party deserialization sinks (
dill.load,dill.loads,jsonpickle.decode,joblib.load) were missing from_SERIALISATION_SINKSin taint tracking, allowing validation provenance to persist on untrusted payloads.🎯 Impact: Untrusted data flowing into these dangerous deserialization functions might not be properly tracked as
UNKNOWN_RAW, leading to false negatives in security scanning.đź”§ Fix: Added the missing unconditional third-party deserializers to the core
_SERIALISATION_SINKSmapping. Conditionally unsafe sinks (numpy.load,torch.load) were intentionally omitted.âś… Verification: Run
make testandmake scan-self. Golden identity tests regenerated.PR created automatically by Jules for task 3316159959976357791 started by @tachyon-beep