🛡️ Sentinel: [HIGH] Fix incomplete taint propagation for third-party deserializers - #159
Conversation
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR strengthens Wardline’s taint propagation model by ensuring outputs from additional third-party deserialization entrypoints are conservatively treated as UNKNOWN_RAW, preventing false negatives when untrusted data flows through these routines.
Changes:
- Added
dill.load,dill.loads,jsonpickle.decode,joblib.load, andshelve.opento_SERIALISATION_SINKSso their return values shed provenance toUNKNOWN_RAW. - Recorded the incident/learning in
.jules/sentinel.mdfor future prevention.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wardline/scanner/taint/variable_level.py | Expands _SERIALISATION_SINKS to include missing third-party deserializers so taint propagation fail-closes to UNKNOWN_RAW. |
| .jules/sentinel.md | Documents the taint propagation gap and the preventative guidance for future sink additions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
🚨 Severity: HIGH
💡 Vulnerability: Third-party deserialization functions (
dill.load,jsonpickle.decode, etc.) were missing from core taint propagation mappings, causing untrusted data flows through these functions to not be properly tracked asUNKNOWN_RAW.🎯 Impact: This could lead to false negatives where the analyzer fails to detect unsafe data reaching sensitive sinks after passing through these deserialization routines.
🔧 Fix: Added the missing unconditional deserialization sinks (
dill.load,dill.loads,jsonpickle.decode,joblib.load,shelve.open) to_SERIALISATION_SINKSinsrc/wardline/scanner/taint/variable_level.py.✅ Verification: Ran
make testand verified the core propagation mapping correctly includes the new sinks.PR created automatically by Jules for task 11520902516335630282 started by @tachyon-beep