Skip to content

🛡️ Sentinel: [HIGH] Fix incomplete taint propagation for third-party deserializers - #159

Open
tachyon-beep wants to merge 2 commits into
mainfrom
sentinel/fix-taint-propagation-third-party-deserializers-11520902516335630282
Open

🛡️ Sentinel: [HIGH] Fix incomplete taint propagation for third-party deserializers#159
tachyon-beep wants to merge 2 commits into
mainfrom
sentinel/fix-taint-propagation-third-party-deserializers-11520902516335630282

Conversation

@tachyon-beep

Copy link
Copy Markdown
Collaborator

🚨 Severity: HIGH
💡 Vulnerability: Third-party deserialization functions (dill.load, jsonpickle.decode, etc.) were missing from core taint propagation mappings, causing untrusted data flows through these functions to not be properly tracked as UNKNOWN_RAW.
🎯 Impact: This could lead to false negatives where the analyzer fails to detect unsafe data reaching sensitive sinks after passing through these deserialization routines.
🔧 Fix: Added the missing unconditional deserialization sinks (dill.load, dill.loads, jsonpickle.decode, joblib.load, shelve.open) to _SERIALISATION_SINKS in src/wardline/scanner/taint/variable_level.py.
✅ Verification: Ran make test and verified the core propagation mapping correctly includes the new sinks.


PR created automatically by Jules for task 11520902516335630282 started by @tachyon-beep

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI lite review requested due to automatic review settings August 22, 2026 16:30
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens Wardline’s taint propagation model by ensuring outputs from additional third-party deserialization entrypoints are conservatively treated as UNKNOWN_RAW, preventing false negatives when untrusted data flows through these routines.

Changes:

  • Added dill.load, dill.loads, jsonpickle.decode, joblib.load, and shelve.open to _SERIALISATION_SINKS so their return values shed provenance to UNKNOWN_RAW.
  • Recorded the incident/learning in .jules/sentinel.md for future prevention.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/wardline/scanner/taint/variable_level.py Expands _SERIALISATION_SINKS to include missing third-party deserializers so taint propagation fail-closes to UNKNOWN_RAW.
.jules/sentinel.md Documents the taint propagation gap and the preventative guidance for future sink additions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants