🛡️ Sentinel: Fix missing unsafe serialization sinks in taint tracking - #157
🛡️ Sentinel: Fix missing unsafe serialization sinks in taint tracking#157tachyon-beep wants to merge 2 commits into
Conversation
The `dill`, `jsonpickle`, `joblib`, and `torch` deserialization sinks were not mapped in `_SERIALISATION_SINKS`, meaning validation provenance would not be properly shed when crossing these boundaries. Added `dill.load`, `dill.loads`, `jsonpickle.decode`, `joblib.load`, and `torch.load` to `_SERIALISATION_SINKS` in `src/wardline/scanner/taint/variable_level.py`. `numpy.load` was intentionally left out because it's conditionally unsafe based on `allow_pickle`. Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Updates Wardline’s level-2 taint propagation to treat additional third-party deserialization functions as serialization-boundary sinks, ensuring validation provenance is shed (returning UNKNOWN_RAW) when data crosses these boundaries.
Changes:
- Added
dill.load,dill.loads,jsonpickle.decode,joblib.load, andtorch.loadto_SERIALISATION_SINKS. - Ensures these calls are consistently treated as provenance-shedding boundaries during
_resolve_callresolution (including alias-closure behavior viabuild_call_taint_map).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The `dill`, `jsonpickle`, `joblib`, and `torch` deserialization sinks were not mapped in `_SERIALISATION_SINKS`, meaning validation provenance would not be properly shed when crossing these boundaries. Added `dill.load`, `dill.loads`, `jsonpickle.decode`, `joblib.load`, and `torch.load` to `_SERIALISATION_SINKS` in `src/wardline/scanner/taint/variable_level.py`. `numpy.load` was intentionally left out because it's conditionally unsafe based on `allow_pickle`. Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
🚨 Severity: MEDIUM
💡 Vulnerability: The
dill,jsonpickle,joblib, andtorchdeserialization sinks were not mapped in_SERIALISATION_SINKS, meaning validation provenance would not be properly shed when crossing these boundaries.🎯 Impact: This could lead to false negatives if tainted data flows through these untracked boundaries, resulting in missed remote code execution vectors.
🔧 Fix: Added
dill.load,dill.loads,jsonpickle.decode,joblib.load, andtorch.loadto_SERIALISATION_SINKSinsrc/wardline/scanner/taint/variable_level.py.numpy.loadwas intentionally left out because it's conditionally unsafe based onallow_pickle.✅ Verification: Verified using
make test,make typecheckandmake lint.PR created automatically by Jules for task 16981414530030586415 started by @tachyon-beep