fix(cli): prevent session hook from inheriting repository dotenv - #143
Closed
tachyon-beep wants to merge 1 commit into
Closed
fix(cli): prevent session hook from inheriting repository dotenv#143tachyon-beep wants to merge 1 commit into
tachyon-beep wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
Superseded by #149: same commit rebased onto |
tachyon-beep
deleted the
codex/fix-vulnerability-in-background-analyze
branch
September 1, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
loomweave analyzewhilemain()may already have loaded a repository.env, which lets repo-controlled loader/plugin environment variables reach the child and enable code-execution vectors..envvalues from being loaded for hook commands while preserving the background analyze behavior.Description
should_load_dotenvincrates/loomweave-cli/src/main.rsto also excludecli::Command::Hook { .. }from loading repository.envand extend the doc comment to describe the rationale.session_start_hook_does_not_load_dotenvincrates/loomweave-cli/src/main.rstests to prevent regressions forhook session-start.Testing
cargo fmt --check, which completed successfully.cargo test -p loomweave-cli tests::session_start_hook_does_not_load_dotenv -- --exact, and the test passed (1 passed; 0 failed).loomweave-cliduring development; no test failures were observed.Codex Task