Skip to content

fix: Allow internal DTD/entities in FVDL parsing while still blocking external XXE #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmadhur87 wants to merge 1 commit into from
Closed

fix: Allow internal DTD/entities in FVDL parsing while still blocking external XXE #1118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...core/fcli-ssc/src/main/java/com/fortify/cli/ssc/action/helper/SSCActionSpelFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,9 @@ private final String processFpr(RawResponse r, Function<JsonNode, Boolean> consu

private final void processAuditFvdl(InputStream is, Function<JsonNode, Boolean> consumer) throws XMLStreamException {
var factory = XMLInputFactory.newInstance();
// Disable DTD processing and external entity resolution to prevent XXE attacks
factory.setProperty(XMLInputFactory.SUPPORT_DTD, false);
// Allow DTD processing (FVDL rule descriptions may declare internal-only entities,
// e.g. &reg;/&trade;), but block resolution of external entities/DTDs to prevent XXE (CWE-611).
factory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false);
factory.setProperty(XMLConstants.ACCESS_EXTERNAL_DTD, "");
var reader = factory.createXMLStreamReader(is);
while(reader.hasNext()) {
Expand Down
Loading