Conversation
feat: `fod sast-scan start` add support for `--scan-policy` fix: `fod sast-scan start` no longer overrides existing Scan Policy if no `--scan-policy` is not supplied (fixes fortify#1095)
There was a problem hiding this comment.
🟢 Approval recommended
The changes are focused, consistent with existing request handling, and include relevant automated coverage.
Pull request overview
Adds FoD SAST scan-policy support across setup and start commands, including endpoint-specific legacy mappings and preservation of configured policies.
Changes:
- Adds
--scan-policyoptions and localized help text. - Normalizes case-insensitive policy values and legacy representations.
- Adds unit and functional coverage for policy fields and CLI help.
File summaries
| File | Description |
|---|---|
FoDScanSastHelper.java |
Normalizes policies and adds them to start requests. |
FoDSastScanSetupCommand.java |
Sends normalized setup policy. |
FoDSastScanStartCommand.java |
Applies explicit or configured release policy. |
| Request/descriptor classes | Adds scan-policy fields. |
FoDMessages.properties |
Documents the new options. |
| Test files | Covers normalization and CLI help/output. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--scan-policytofod sast-scan setupandfod sast-scan start.SecurityDevOpsLegacyFoD_LegacyFoD_Legacy_Validation
scan-policyapplied to a live FoD tenant.