fix: convert FoD identifier fields from int to long to prevent overflow - #1091
Merged
rsenden merged 5 commits intoSep 18, 2026
Merged
Conversation
jmadhur87
marked this pull request as ready for review
September 7, 2026 05:41
jmadhur87
requested review from
kadraman and
rsenden
and removed request for
rsenden
September 7, 2026 15:00
rsenden
requested changes
Sep 18, 2026
rsenden
left a comment
rsenden
left a comment
Contributor
There was a problem hiding this comment.
I think this looks mostly fine, just wondering though why you changed FoDAppDescriptor::applicationId from String to Long, whereas you didn't do the same for FoDReleaseDescriptor::applicatonId, nor for the releaseId and microserviceId fields in the various descriptors.
Please ensure we're using a consistent approach for these id's; either treat them all as strings, or treat them all as longs.
…1B limit overflow)
jmadhur87
force-pushed
the
mjain6/fod-id-int-to-long-migration
branch
from
September 18, 2026 11:24
e19bb8d to
dbc0cae
Compare
Contributor
Author
|
@rsenden For consistency, reverted the applicationId from long to string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes potential overflow bugs in FoD identifier handling. Several FoD IDs (report, release, user, group, attribute, scan, entitlement) were stored as Integer/int, which breaks once an ID grows past ~2.1 billion. Converted them to long.
Affects several commands: release update/create (--owner/--app-owner), app create (--owner), issue update (--user), group/user update (--add-users/--remove-users/--add-groups/--remove-groups), sast/mast/dast-scan setup/start (--entitlement-id), attribute and report get/update/delete (--attribute-id/--report-id), plus output field types on several list/get commands.