Repository navigation
parser_syslog: do not skip unmatched header fields in the RFC 5424 re… - #5643
Closed
Shriraj1901 wants to merge 1 commit into
Closed
Shriraj1901 wants to merge 1 commit into
Shriraj1901 wants to merge 1 commit into
Conversation
…gexp parser parse_plain calls re.match(text, idx), but Regexp#match with a position only starts searching there; it does not anchor the match. When the host, ident, pid, msgid or structured data at idx did not match, the regexp engine could match further on in the text, so the record got values from the wrong place and the text in between was dropped without any warning. For example, a hostname with a non-ASCII character returned "st" as the host, and a header split by a line break returned the second line's fields as the record. Anchor the RFC 5424 regexp with \G so that a header that does not match at idx is reported as not matched. Fixes fluent#5630 Signed-off-by: shreeraj <shreerajjadhav19@gmail.com>
Contributor
|
Thank you for working on this. #5641 was opened a few hours earlier for the same issue, with the same change to the regexp and the same test inputs, so I'm closing this one as a duplicate. Sorry about the overlap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gexp parser
parse_plain calls re.match(text, idx), but Regexp#match with a position only starts searching there; it does not anchor the match. When the host, ident, pid, msgid or structured data at idx did not match, the regexp engine could match further on in the text, so the record got values from the wrong place and the text in between was dropped without any warning.
For example, a hostname with a non-ASCII character returned "st" as the host, and a header split by a line break returned the second line's fields as the record.
Anchor the RFC 5424 regexp with \G so that a header that does not match at idx is reported as not matched.
Fixes #5630
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Docs Changes:
Release Note: