Repository navigation
parser_syslog: require the space after VERSION to detect RFC 5424 #5642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rafayqayyum
wants to merge
1
commit into
fluent:master
Choose a base branch
from
rafayqayyum:syslog-detect-rfc5424-version-space
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUST: This makes
autoreject some messages that master parses. On master, every message that starts with<PRI>and a non-zero digit goes to the RFC 5424 parsers.parse_rfc5424_regexfinds VERSION withRFC5424_PRI_REGEXP(/\A<(?<pri>\d{1,3})>\d\d{0,2}\s/), and its final\salso accepts a tab or a newline after VERSION. The string parserparse_rfc5424skips to the first space after PRI. The new detection accepts only a space right after VERSION, so these messages now go to the RFC 3164 path.For example, take
in_syslogwith onlymessage_format autoin<parse>(so the defaultparser_engine regexp), and send this message over UDP. It has a tab after VERSION."<14>1\t2026-04-25T16:43:29Z host app 123 ID - msg"syslog.user.infowith{"host" => "host", "ident" => "app", "pid" => "123", "msgid" => "ID", "extradata" => "-", "message" => "msg"}.[error]: invalid input ... error_class=Fluent::TimeParser::TimeParseError.With
parser_engine string,"<14>1\t 2026-04-25T16:43:29Z host app 123 ID - msg"(a tab and then a space) is parsed on master and returns no record with this PR. A newline in place of the tab behaves the same way with both engines.Using
\shere keeps master's behavior for these messages. It still fixes the message from #5631, because the year has four digits and VERSION has at most three.Please also add the following regression test to
SyslogParserTestintest/plugin/test_parser_syslog.rb. It passes on master, fails on the current HEAD, and passes with the suggestion above. With both changes, all tests in the file pass.