Repository navigation
Backport(v1.19): test_out_http: use an unused port for each test case (#5618) - #5639
Merged
Merged
Conversation
**Which issue(s) this PR fixes**:
Fixes #
**What this PR does / why we need it**:
The HTTP server thread was kept in a class variable, and it is shared
with sub test cases. Each sub test case set it to nil at startup, so the
server of the parent test case was never stopped and kept port
19880. The dynamic endpoint host validation tests used the same port, so
their server could not bind it.
Fixed ports can also conflict with other processes or with tests that
run in parallel.
Before: The server thread died with "Address already in use -
bind(2) for 127.0.0.1:19880 (Errno::EADDRINUSE)".
After: Each test case keeps its own server in a class instance
variable, and uses a port from unused_port.
**Docs Changes**:
N/A
**Release Note**:
N/A
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Watson1978
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #5618
Fixes #
What this PR does / why we need it:
The HTTP server thread was kept in a class variable, and it is shared with sub test cases. Each sub test case set it to nil at startup, so the server of the parent test case was never stopped and kept port
19880. The dynamic endpoint host validation tests used the same port, so their server could not bind it.
Fixed ports can also conflict with other processes or with tests that run in parallel.
Before: The server thread died with "Address already in use -
bind(2) for 127.0.0.1:19880 (Errno::EADDRINUSE)".
After: Each test case keeps its own server in a class instance
variable, and uses a port from unused_port.
Docs Changes:
N/A
Release Note:
N/A