Repository navigation
Backport(v1.19): out_forward: use the standby node after a failed ACK or handshake (#5623) - #5638
Merged
Merged
Conversation
) **Which issue(s) this PR fixes**: Fixes #5620 **What this PR does / why we need it**: A failed ACK or a failed handshake disables a node outside the heartbeat, and the heartbeat timer did not rebuild the weight array for a node that was already disabled. So the standby node was never used, and every flush failed with `NoNodesAvailable` until the primary came back. This remembers the availability of each node when the weight array is built, and the heartbeat timer rebuilds it when the availability has changed. The same applies to a node disabled at startup by `ignore_network_errors_at_startup`, so the standby is now used there too. With `heartbeat_type udp`, a primary that is alive but fails one ACK is replaced by the standby until its next UDP heartbeat response arrives, and `using standby node` and `recovered forwarding server` are logged. Before this change, flushes failed with `NoNodesAvailable` during that time. **Docs Changes**: None. **Release Note**: out_forward: use the standby node after a failed ACK or handshake When a failed ACK (with `require_ack_response`) or a failed handshake (with `<security>`) disabled the primary, the standby node was not used, and every flush failed with `NoNodesAvailable` until the primary came back. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Kentaro Hayashi <kenhys@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Watson1978
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #5623
Fixes #5620
What this PR does / why we need it:
A failed ACK or a failed handshake disables a node outside the heartbeat, and the heartbeat timer did not rebuild the weight array for a node that was already disabled. So the standby node was never used, and every flush failed with
NoNodesAvailableuntil the primary came back. This remembers the availability of each node when the weight array is built, and the heartbeat timer rebuilds it when the availability has changed.The same applies to a node disabled at startup by
ignore_network_errors_at_startup, so the standby is now used there too. Withheartbeat_type udp, a primary that is alive but fails one ACK is replaced by the standby until its next UDP heartbeat response arrives, andusing standby nodeandrecovered forwarding serverare logged. Before this change, flushes failed withNoNodesAvailableduring that time.Docs Changes:
None.
Release Note:
out_forward: use the standby node after a failed ACK or handshake
When a failed ACK (with
require_ack_response) or a failed handshake (with<security>) disabled the primary, the standby node was not used, and every flush failed withNoNodesAvailableuntil the primary came back.🤖 Generated with Claude Code