Skip to content

Backport(v1.19): test_child_process: Exercise scrubbing during transcoding (#5626) - #5637

Merged
Watson1978 merged 1 commit into
v1.19from
backport-to-v1.19/pr5626
Nov 15, 2026
Merged

Watson1978 merged 1 commit into
v1.19from
backport-to-v1.19/pr5626

Conversation

@github-actions

Copy link
Copy Markdown

Which issue(s) this PR fixes:
Backport #5626
Fixes #4058

What this PR does / why we need it:
Ruby 3.3 and later preserve binary input when the external encoding
is ASCII-8BIT. Use EUC-JP input containing both an invalid byte and a
valid byte sequence with no Unicode mapping to exercise
invalid: :replace and undef: :replace during transcoding to UTF-8.
Verify that valid characters survive and that both default and custom
replacement characters work.

Docs Changes:
None.

Release Note:
None.

Assisted-by: GPT-6.1 Sol [Codex]

**Which issue(s) this PR fixes**:
Fixes #4058

**What this PR does / why we need it**:
Ruby 3.3 and later preserve binary input when the external encoding
is ASCII-8BIT. Use EUC-JP input containing both an invalid byte and a
valid byte sequence with no Unicode mapping to exercise
`invalid: :replace` and `undef: :replace` during transcoding to UTF-8.
Verify that valid characters survive and that both default and custom
replacement characters work.

**Docs Changes**:
None.

**Release Note**:
None.

Assisted-by: GPT-6.1 Sol [Codex]

---------

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Watson1978 Watson1978 added the CI Test/CI issues label Nov 15, 2026
@Watson1978 Watson1978 added this to the v1.19.5 milestone Nov 15, 2026
@Watson1978
Watson1978 merged commit 47a8f1c into v1.19 Nov 15, 2026
21 checks passed
@Watson1978
Watson1978 deleted the backport-to-v1.19/pr5626 branch November 15, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants