Repository navigation
test_in_tail: fix flaky worker unwatch test by disabling the periodic refresh - #5599
Merged
Merged
Conversation
… refresh test_worker_completion_drains_file_during_unwatch unwatches the file, but the file still matches path. The periodic refresh finds it again and reads it from the head, so the line is emitted twice if the test runs longer than about one second. create_driver(config) puts the common config on the left of +, and the left side wins. So the refresh_interval and rotate_wait of the neighboring rotation test were not applied either. Configure both tests without the common config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
What this PR does / why we need it:
test_worker_completion_drains_file_during_unwatch(added in #5529) unwatches the file, but the file still matchespath. The periodic refresh finds it again and reads it from the head, so the line is emitted twice if the test runs longer than about one second. It passes now only because the test usually ends before the first refresh.The neighboring rotation test sets
refresh_interval 1handrotate_wait 1s, but they are not applied.create_driver(config)puts the common config on the left of+, and the left side wins. So both tests run withrefresh_interval 1sandrotate_wait 2s. This PR configures both tests without the common config and setsrefresh_interval 1hfor the unwatch test as well.Docs Changes:
None.
Release Note:
None. This only fixes the tests.
🤖 Generated with Claude Code