Repository navigation
out_forward: document the handling of a failed ack - #722
Open
SahinurDEV wants to merge 1 commit into
Open
SahinurDEV wants to merge 1 commit into
SahinurDEV wants to merge 1 commit into
Conversation
Describe what fluent/fluentd#5627 changes when the ack of a chunk fails: the server is detached for recover_wait while another server can take the chunk (a standby server is used if needed), the last available server is kept and a retry is counted with AckResponseError, and the behavior with heartbeat_type none. Signed-off-by: SahinurDEV <68515168+SahinurDEV@users.noreply.github.com>
👷 Deploy request for fluentd-docs pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents the
out_forwardchanges in fluent/fluentd#5627 for a failed ack withrequire_ack_response(fluent/fluentd#5619):require_ack_response: what happens when the ack of a chunk fails. If another available server with a positiveweightcan take the chunk, the server whose ack failed is detached for at leastrecover_wait(10 seconds by default) and the chunk goes to the other servers, astandbyserver if needed, without counting a retry. Before this change, a transport heartbeat could bring the server back at the next heartbeat. If no other server can take the chunk, the last available server is kept, and a retry is counted withAckResponseError, soretry_wait,retry_max_times,retry_timeoutand<secondary>apply. A late ack failure after the delayed commit timeout has rolled the chunk back does not count a second retry.recover_wait: it now also applies after a failed ack.heartbeat_type none: servers are always regarded as available, except that a server whose ack failed is kept out forrecover_waitwhile another server can take its chunks. A standby server is used in the meantime.fluent/fluentd#5627 is not merged yet, so this should be merged after it is released. Please let me know which version to put in the text then, or if you prefer a version note here.