fix(trash): use host gio trash via flatpak-spawn - #237
Open
sallysyruper wants to merge 2 commits into
Open
Conversation
Author
|
@heliguy4599 can you please check this and if you approve the code, release a minor version with the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #232
Run
gio trashon the host withflatpak-spawn --host gio trash. This uses the host's native trash for both files and directories.Items appear in the user's normal trash and can be restored.
Keeps the app usable while @heliguy4599 work in the typescript rewrite
*extra: update .gitignore