Skip to content

builder: Add AppStream compose icon policy option - #767

Closed
razzeee wants to merge 1 commit into
flatpak:mainfrom
razzeee:appstream-compose-icon-policy
Closed

builder: Add AppStream compose icon policy option#767
razzeee wants to merge 1 commit into
flatpak:mainfrom
razzeee:appstream-compose-icon-policy

Conversation

@razzeee

@razzeee razzeee commented Aug 8, 2026

Copy link
Copy Markdown

Hopefully allows us to start generating bigger icons on flathub if we want that

@bbhtt

bbhtt commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator
  1. Wrong commit prefix and no commit message
  2. Variable names and arguments not following the pattern in use
  3. There is no need to checksum cache
  4. The way it is implemented this is not backwards compatible
  5. AI slop comments in tests The first time I hear of "retina" and "non-retina" icons.

In general if you are unable to distil and add human moderation to the AI output I cannot be bothered. You can just open an issue and wait. This also needs to wait on #664 anyways.

@bbhtt bbhtt closed this Aug 8, 2026
@razzeee

razzeee commented Aug 8, 2026

Copy link
Copy Markdown
Author

I'm sorry I called it retina, I'm blanking on the naming. That's what I usually use when talking to designers, as they know it from macOS.

What about the names is not correct? I changed them to start with opt_ specifically cause there is old code like that.

@razzeee

razzeee commented Aug 8, 2026

Copy link
Copy Markdown
Author

Updated accordingly as far as I got your comment, kinda hard to get meaning out of it in most places, let me know if it moved into the correct direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants