Skip to content

gencodec generates vendored import path instead of regular path #8

Description

@dimroc

When running go generate ./..., gencodec writes the vendored import paths rather than the correct ones:

As seen here where we are using golang/dep to vendor our dependencies: smartcontractkit/chainlink#680 (comment)

Source

//go:generate gencodec -dir . -type Log -field-override logMarshaling -out gen_log_json.go

// Log represents a contract log event. These events are generated by the LOG opcode and
// stored/indexed by the node.
type Log struct {
...

Current Behavior

// Code generated by github.com/fjl/gencodec. DO NOT EDIT.

package store

import (
	"encoding/json"
	"errors"

	"github.com/smartcontractkit/chainlink/vendor/github.com/ethereum/go-ethereum/common"
	"github.com/smartcontractkit/chainlink/vendor/github.com/ethereum/go-ethereum/common/hexutil"
)

...

Expected behavior

// Code generated by github.com/fjl/gencodec. DO NOT EDIT.

package store

import (
	"encoding/json"
	"errors"

	"github.com/ethereum/go-ethereum/common"
	"github.com/ethereum/go-ethereum/common/hexutil"
)

...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions