Repository navigation
Honor OTEL service identity and release PyFly v26.10.06 - #189
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyFly's implicit
service-name: ${pyfly.app.name}default and explicit SDK resource assignment masked the service identity injected by the platform. Workloads such ascore-flydocs,core-flydocs-worker, andcore-flydocs-bbox-workerconsequently exported traces and metrics under the samepyfly-appname.Remove that implicit override and resolve newly created trace/metric provider identity through the shared helper: explicit nonempty PyFly service-name override, then the SDK's standard
OTEL_SERVICE_NAME/OTEL_RESOURCE_ATTRIBUTEShandling, then application name andpyfly-app. Preserve other resource attributes, SDK parsing, custom/global providers, and provider ownership.Add a real local OTLP/HTTP regression matrix that emits spans and counters, decodes both protobuf payloads, and checks precedence, defaults loading, empty values, encoded attributes, and neighboring resource attributes. Six scenarios failed before the fix; all eleven pass afterward. Synchronize versions to v26.10.06 (package 26.10.6), active download links, README badge, configuration/observability documentation, and both book editions. Explain explicit overrides and the need to restart existing providers.
Validation:
Exact-head CI passed on d5ebb02: Python 3.12/3.13, SQLAlchemy 2.0, lint/types, documentation, package build, browser and installed distributions. Both candidate PDF/EPUB editions were built and their covers and changed identity pages visually reviewed. No production deployment or historical telemetry mutation is included.
Closes #151.