Repository navigation
Auto-update dependencies. - #1362
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase SDK version from 12.19.0 to 13.0.0 across multiple index.html files in various project directories. A duplicate import of the firebase-firestore-compat.js script was found in Node-1st-gen/fulltext-search-firestore/public/index.html, which should be removed to prevent redundant network requests and script executions.
Comment on lines
+61
to
+62
| <script src="/__/firebase/13.0.0/firebase-firestore-compat.js"></script> | ||
| <script src="/__/firebase/13.0.0/firebase-firestore-compat.js"></script> |
Contributor
There was a problem hiding this comment.
The firebase-firestore-compat.js script is imported twice. Removing the duplicate import will clean up the HTML and avoid redundant network requests or script executions.
Suggested change
| <script src="/__/firebase/13.0.0/firebase-firestore-compat.js"></script> | |
| <script src="/__/firebase/13.0.0/firebase-firestore-compat.js"></script> | |
| <script src="/__/firebase/13.0.0/firebase-firestore-compat.js"></script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought to you by your friendly Repository Gardener.