Repository navigation
revert: point the samples at us-central1 again - #1347
Merged
Merged
Conversation
Reverts the region strings from #1327 (90765b3). That change assumed the default region for Cloud Functions had moved to us-east4. It hasn't: the Firebase CLI still falls back to us-central1 for HTTP, callable, scheduled, and task queue functions, and none of these samples set a region. us-east4 is the new default for App Hosting and Data Connect, not for Functions. Kept from #1327: - the `.value` on SupportedRegion in the Python task queue samples - the requiresRole/requiresAPI import from the firebase-functions root - the us-east1 example URLs in Node/quickstarts/https-time-server, which deploys to us-west1 and us-east1 Supersedes #1346.
jhuleatt
added a commit
that referenced
this pull request
Oct 6, 2026
The Python sample sets no region, so it deploys to us-central1. #1347 puts the other sample URLs back to us-central1 as well.
Contributor
There was a problem hiding this comment.
Code Review
This pull request systematically updates the default region for Firebase Cloud Functions and emulator endpoints from us-east4 to us-central1 across multiple project examples, configuration files, setup scripts, and README documentation in both Node.js and Python. I have no feedback to provide as there are no review comments.
jhuleatt
added a commit
that referenced
this pull request
Oct 7, 2026
The Python sample sets no region, so it deploys to us-central1. #1347 puts the other sample URLs back to us-central1 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1327 changed example URLs, client code, and the Python task queue defaults in 25 samples from
us-central1tous-east4, on the assumption that the default region for Cloud Functions for Firebase had moved. It hasn't. In the Firebase CLI:regionstill deploy tous-central1(FALLBACK_DEPLOYMENT_REGIONinsrc/deploy/functions/services/index.ts).nam5givesus-central1, for example, and global sources such as Pub/Sub giveus-east1.us-east4is the new default for App Hosting and Data Connect, not for Functions.None of the samples touched by #1327 set a region, so they deploy to
us-central1. Their URLs, client code, and queue paths pointed at functions that don't exist. This PR puts the strings back.What's kept from #1327
.valueonSupportedRegionin the Python task queue samples, soqueue_pathandget_function_urlget a string rather than an enum member.requiresRoleandrequiresAPIimport from thefirebase-functionspackage root.us-east1example URLs inNode/quickstarts/https-time-server, which deploys tous-west1andus-east1.Notes
us-east4. I'll close that one.us-east4→us-central1. I checked withgit diff origin/mainthat nothing else changed.Node-1st-gen/spotify-auth/public/popup.htmlwith relative URLs. Whichever of the two lands second needs a one-line rebase.