Skip to content

revert: point the samples at us-central1 again - #1347

Merged
jhuleatt merged 1 commit into
mainfrom
revert/us-east4-region-strings
Oct 7, 2026
Merged

jhuleatt merged 1 commit into
mainfrom
revert/us-east4-region-strings

Conversation

@jhuleatt

@jhuleatt jhuleatt commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Why

#1327 changed example URLs, client code, and the Python task queue defaults in 25 samples from us-central1 to us-east4, on the assumption that the default region for Cloud Functions for Firebase had moved. It hasn't. In the Firebase CLI:

  • HTTP, callable, scheduled, and task queue functions that don't set a region still deploy to us-central1 (FALLBACK_DEPLOYMENT_REGION in src/deploy/functions/services/index.ts).
  • Since CLI v15.17.0 (firebase-tools#10414), new event-triggered functions default to the location of their event source. A Firestore database in nam5 gives us-central1, for example, and global sources such as Pub/Sub give us-east1.
  • us-east4 is the new default for App Hosting and Data Connect, not for Functions.

None of the samples touched by #1327 set a region, so they deploy to us-central1. Their URLs, client code, and queue paths pointed at functions that don't exist. This PR puts the strings back.

What's kept from #1327

  • The .value on SupportedRegion in the Python task queue samples, so queue_path and get_function_url get a string rather than an enum member.
  • The requiresRole and requiresAPI import from the firebase-functions package root.
  • The us-east1 example URLs in Node/quickstarts/https-time-server, which deploys to us-west1 and us-east1.

Notes

Reverts the region strings from #1327 (90765b3). That change assumed
the default region for Cloud Functions had moved to us-east4. It
hasn't: the Firebase CLI still falls back to us-central1 for HTTP,
callable, scheduled, and task queue functions, and none of these
samples set a region. us-east4 is the new default for App Hosting and
Data Connect, not for Functions.

Kept from #1327:
- the `.value` on SupportedRegion in the Python task queue samples
- the requiresRole/requiresAPI import from the firebase-functions root
- the us-east1 example URLs in Node/quickstarts/https-time-server,
  which deploys to us-west1 and us-east1

Supersedes #1346.
jhuleatt added a commit that referenced this pull request Oct 6, 2026
The Python sample sets no region, so it deploys to us-central1. #1347
puts the other sample URLs back to us-central1 as well.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request systematically updates the default region for Firebase Cloud Functions and emulator endpoints from us-east4 to us-central1 across multiple project examples, configuration files, setup scripts, and README documentation in both Node.js and Python. I have no feedback to provide as there are no review comments.

@jhuleatt
jhuleatt merged commit 116e99f into main Oct 7, 2026
19 checks passed
@jhuleatt
jhuleatt deleted the revert/us-east4-region-strings branch October 7, 2026 14:01
jhuleatt added a commit that referenced this pull request Oct 7, 2026
The Python sample sets no region, so it deploys to us-central1. #1347
puts the other sample URLs back to us-central1 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant