Redesign sign-in with the Carbon authentication pattern - #192
Merged
Merged
Conversation
Co-Authored-By: [CC] <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 51.13% 51.09% -0.04%
==========================================
Files 128 128
Lines 12669 12669
==========================================
- Hits 6478 6473 -5
- Misses 5412 5417 +5
Partials 779 779 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fifthsegment
marked this pull request as ready for review
September 26, 2026 07:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release GateSentry 2.4.0 with a redesigned sign-in page built on IBM Carbon v10's authentication-pattern conventions, studied against the shipped Carbon 10.58 component and stylesheet sources (forms, text/password inputs, button sets, spacing, and color tokens).
What changed
AuthShell.svelte+app.css) — replaces the dark gradient card with Carbon's light G10 surface:#f4f4f4backdrop, white card with subtle border/shadow, a blue mark + "GATESENTRY" brand row, and expressive light-weight heading. Narrowed to a 28rem card.login.svelte) — standard CarbonForm(notFluidForm, which is meant for dense in-app forms, not short auth screens),size="xl"inputs (3rem touch targets) with visible labels and properautocompleteattributes, one Clear/Sign inButtonSetrow (secondary + primary), inline field-level errors via the inputs' own invalid state.kind/sizeprop onDownloadCertificateLink(Settings keeps its existing tertiary small usage).tooltipAlignment="end"right-aligns the "Show password" tooltip so it cannot widen the page on narrow screens (replaces Carbon's default 50%-centering that overflowed at 390px).GATESENTRY_VERSION→2.4.0with matchingCHANGELOG.mdnotes.Preserved
/auth/token,on:authenticated, redirect behavior, localStorage hygiene)Validation
make verify— passed (Svelte check 0/0, 76 UI tests, asset build, Go tests, Go build)make validate-assets— passed; embedded assets synchronizedscrollWidth== viewport)🤖 Generated with [CC]