Repository navigation
Fix Carbon UI follow-ups - #191
Merged
Merged
Conversation
…on, services width Co-Authored-By: [CC] <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 51.13% 51.13%
=======================================
Files 128 128
Lines 12669 12669
=======================================
Hits 6478 6478
Misses 5412 5412
Partials 779 779 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fifthsegment
marked this pull request as ready for review
September 25, 2026 21:57
Co-Authored-By: [CC] <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for regressions found in the merged Carbon UI unification (#190):
<ButtonSet stacked>, so Clear and Sign in rendered in a column. Removedstackedso they share one row.logout()navigated to/loginbut the app state stayedauthenticated, so the authenticated branch's catch-all route matched/loginand rendered NotFound until a refresh.headerrightnavnow dispatches aloggedoutevent,globalheaderforwards it, andApp.sveltesetsstate = "login"so the login page renders immediately (mirroring the existingon:authenticatedflow).narrowtoPageShell, centering a 64rem column unlike other routes. Removed it so Services uses the standard page width. The not-found page intentionally stays narrow.This PR also releases GateSentry 2.3.1:
GATESENTRY_VERSIONbumped inmain.gowith matching notes inCHANGELOG.md. Merging will tagv2.3.1and publish the release artifacts.Validation
make ui-check— passed (Svelte check 0 errors/0 warnings; 15 files, 75 tests passed)make frontend-assets+make validate-assets— passed (embedded assets synchronized)make verify— passed (UI checks, asset build/validation, Go tests, Go build)🤖 Generated with [CC]