Skip to content

fix(ci): validate current package metadata before merge - #22

Merged
prudhomm merged 1 commit into
mainfrom
fix/ci-metadata-validation
Oct 30, 2026
Merged

prudhomm merged 1 commit into
mainfrom
fix/ci-metadata-validation

Conversation

@prudhomm

Copy link
Copy Markdown
Member

The main-branch build after #19 failed because locked Twine 6.2.0 rejects Core Metadata 2.5 produced by the current build backend. All Python test jobs passed; this failure was only discovered after merge because the build job skipped pull requests.

Require Twine 7 on Python 3.10+ and refresh the lockfile, while retaining Twine 6.2 for Python 3.9 development compatibility. Run the build/check job for pull requests and all already-configured push events so packaging failures are caught before merge.

Validation:

  • Reproduced the original metadata 2.5 rejection with Twine 6.2.
  • Wheel and source archive both pass twine check with Twine 7.
  • All 227 tests pass on Python 3.9 and Python 3.11.
  • Black, mypy and fatal flake8 checks pass.
  • Lockfile adds only Twine 7; existing locked package versions are retained.

Failed run: https://github.com/feelpp/article.cli/actions/runs/41047992049
Upstream fix: https://twine.readthedocs.io/en/latest/changelog.html#twine-7-0-0-2026-07-27

Use Twine 7 for Python 3.10+ to support Core Metadata 2.5, retaining Twine 6.2 for Python 3.9. Run package builds and validation on pull requests as well as branch pushes.
@prudhomm prudhomm self-assigned this Oct 30, 2026
@prudhomm prudhomm added bug Something isn't working area: ci-cd GitHub Actions and automated validation labels Oct 30, 2026
@prudhomm
prudhomm merged commit c2822a1 into main Oct 30, 2026
8 checks passed
@prudhomm
prudhomm deleted the fix/ci-metadata-validation branch October 30, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd GitHub Actions and automated validation bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant