Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions web/src/components/player/series-player-chrome.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { usePlayerControlsVisible } from "@/components/player/use-player-control
import {
episodesForSeason,
findNextEpisode,
uniqueSeasons,
seasonNumbersForMenu,
type SeriesEpisodeOption,
} from "@/lib/series-nav";
import { SkipIntroAction } from "@/components/player/skip-intro-action";
Expand All @@ -19,6 +19,8 @@ type SeriesPlayerChromeProps = {
currentEpisode: number;
showName: string;
episodes: SeriesEpisodeOption[];
/** Season numbers from show catalog (preferred over inferring from loaded episodes). */
catalogSeasons?: number[];
seasonsLoading?: boolean;
onSelectEpisode: (path: string) => void;
onUploadSubtitle?: (file: File) => Promise<void>;
Expand Down Expand Up @@ -48,6 +50,7 @@ export function SeriesPlayerChrome({
currentEpisode,
showName,
episodes,
catalogSeasons,
seasonsLoading,
onSelectEpisode,
onUploadSubtitle,
Expand All @@ -62,7 +65,10 @@ export function SeriesPlayerChrome({
const fileRef = useRef<HTMLInputElement>(null);
const [dismissedKey, setDismissedKey] = useState<string | null>(null);

const seasons = useMemo(() => uniqueSeasons(episodes), [episodes]);
const seasons = useMemo(
() => seasonNumbersForMenu(catalogSeasons, episodes),
[catalogSeasons, episodes],
);
const seasonEpisodes = useMemo(
() => episodesForSeason(episodes, currentSeason),
[episodes, currentSeason],
Expand Down
2 changes: 2 additions & 0 deletions web/src/components/player/videojs-player.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ type SeriesChrome = {
episode: number;
showName: string;
episodes: SeriesEpisodeOption[];
catalogSeasons?: number[];
seasonsLoading?: boolean;
onSelectEpisode: (path: string) => void;
};
Expand Down Expand Up @@ -190,6 +191,7 @@ export function VideoJSPlayer({
currentEpisode={seriesChrome.episode}
showName={seriesChrome.showName}
episodes={seriesChrome.episodes}
catalogSeasons={seriesChrome.catalogSeasons}
seasonsLoading={seriesChrome.seasonsLoading}
onSelectEpisode={seriesChrome.onSelectEpisode}
onUploadSubtitle={onUploadSubtitle}
Expand Down
25 changes: 24 additions & 1 deletion web/src/lib/series-nav.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ export type SeriesNavResult = {
seriesComplete: boolean;
};

/** Normalize media paths for equality (route params vs catalog JSON). */
export function normalizeMediaPath(path: string): string {
const trimmed = path.replace(/^\/+/, "").replaceAll("\\", "/");
try {
return decodeURIComponent(trimmed);
} catch {
return trimmed;
}
}

/** Flat list of episodes sorted by season then episode number. */
export function sortEpisodes(episodes: SeriesEpisodeOption[]): SeriesEpisodeOption[] {
return [...episodes].sort((a, b) => {
Expand All @@ -26,7 +36,8 @@ export function findNextEpisode(
currentPath: string,
): SeriesNavResult {
const sorted = sortEpisodes(episodes);
const index = sorted.findIndex((ep) => ep.path === currentPath);
const needle = normalizeMediaPath(currentPath);
const index = sorted.findIndex((ep) => normalizeMediaPath(ep.path) === needle);
if (index < 0) {
return { next: null, seasonComplete: false, seriesComplete: false };
}
Expand All @@ -49,3 +60,15 @@ export function episodesForSeason(
export function uniqueSeasons(episodes: SeriesEpisodeOption[]): number[] {
return [...new Set(episodes.map((ep) => ep.season))].sort((a, b) => a - b);
}

/** Prefer catalog season headers; fall back to seasons inferred from loaded episodes. */
export function seasonNumbersForMenu(
catalogSeasons: number[] | undefined,
episodes: SeriesEpisodeOption[],
): number[] {
if (catalogSeasons && catalogSeasons.length > 0) {
return [...new Set(catalogSeasons)].sort((a, b) => a - b);
}

return uniqueSeasons(episodes);
}
39 changes: 30 additions & 9 deletions web/src/pages/player/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,34 +173,53 @@ export default function PlayerPage() {
},
});

const seasons = showQuery.data?.seasons ?? [];
const catalogSeasonNumbers = useMemo(() => {
const list = showQuery.data?.seasons ?? [];
return list.map((season) => season.season ?? 0);
}, [showQuery.data?.seasons]);
const episodesQuery = useQuery({
queryKey: [
"player-series-episodes",
series?.librarySlug,
series?.showKey,
seasons.map((s) => s.season).join(","),
catalogSeasonNumbers.join(","),
],
enabled: Boolean(series?.librarySlug && series?.showKey && seasons.length > 0),
enabled: Boolean(series?.librarySlug && series?.showKey && catalogSeasonNumbers.length > 0),
queryFn: async () => {
const pages = await Promise.all(
seasons.map(async (season) => {
const current = series!.season;
const ordered = [...catalogSeasonNumbers].sort((a, b) => {
if (a === current) {
return -1;
}
if (b === current) {
return 1;
}
return a - b;
});

// allSettled: one slow/failing season must not wipe the whole menu (Melrose = 7×~32).
const settled = await Promise.allSettled(
ordered.map(async (season) => {
const response = await getApiCatalogByLibrarySlugShowsByShowKeySeasonsBySeasonEpisodes({
path: {
librarySlug: series!.librarySlug,
showKey: series!.showKey,
season: season.season ?? 0,
season,
},
});
if (response.error || !response.data) {
throw new Error("season episodes failed");
throw new Error(`season ${season} episodes failed`);
}
return response.data.episodes ?? [];
}),
);

const options: SeriesEpisodeOption[] = [];
for (const page of pages) {
for (const ep of page) {
for (const result of settled) {
if (result.status !== "fulfilled") {
continue;
}
for (const ep of result.value) {
if (!ep.path) {
continue;
}
Expand Down Expand Up @@ -242,10 +261,12 @@ export default function PlayerPage() {
episode: series.episode,
showName: series.showName,
episodes: episodesQuery.data ?? [],
catalogSeasons: catalogSeasonNumbers,
seasonsLoading: showQuery.isLoading || episodesQuery.isLoading,
onSelectEpisode: selectEpisode,
};
}, [
catalogSeasonNumbers,
episodesQuery.data,
episodesQuery.isLoading,
mediaPath,
Expand Down
Loading