fix(web): prevent accessing null event.currentTarget in async handlers - #5
Conversation
This commit fixes a runtime TypeError ("Cannot set properties of null")
that occurs when trying to reset an `<input type="file">`'s value
after an asynchronous upload process. `event.currentTarget` can become
null asynchronously. The solution synchronously saves a reference to
`event.target` before starting the asynchronous work, and uses that
reference in the `finally` block to clear the input value.
The identical fix is applied to both `website-builder.tsx` and
`language-manager.tsx`.
Co-authored-by: fdaei <81993335+fdaei@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes an issue where
event.currentTargetwould be accessed asynchronously, resulting in a TypeError. This occurred during file uploads. Savingevent.targetsynchronously solves this.PR created automatically by Jules for task 18363888274915932256 started by @fdaei