fix(compat): terminate itoa output reliably - #256
Draft
arazmj wants to merge 1 commit into
Draft
Conversation
Replace the non-portable stringbuf-backed implementation with direct integer conversion so callers receive a terminated string on Unix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fbraz3
marked this pull request as draft
August 17, 2026 04:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
itoaimplementation's non-portablestd::stringbuf::pubsetbufuse with direct conversionINT_MINMultiplayer impact
The previous libc++ implementation did not reliably write into the caller-provided buffer. Multi-exit transports therefore built corrupted logical bone names such as
ExitStart0..., fell back to the transport position, and desynchronized macOS from Windows while unloading passengers.With this change, replaying the reported Infantry General Troop Crawler unload changes the macOS frame-7400 CRC from
9C0ABBE5to the exact Windows CRCF9A12D0B.Validation
GeneralsXandGeneralsXZHwith themacos-vulkanpresetINT_MIN, hexadecimal, and invalid-base conversions