Repository navigation
fix(validate): skip runtime-injected tool parameters - #157
Merged
Asaf-prog merged 1 commit intoNov 2, 2026
Merged
Conversation
The parameter-description check warned about parameters LangChain fills in at runtime and leaves out of the model-facing tool schema, e.g. `config: RunnableConfig` produced "parameter "config" is missing a description" although `tool_call_schema` exposes only the other params. Skip them in the static scan, mirroring langchain_core's filtering: `callbacks`/`run_manager` by name, a bare `RunnableConfig` (an optional one is still shown to the model), `ToolRuntime`, and `Annotated[...]` with an `Injected*` marker (InjectedToolArg, InjectedToolCallId, LangGraph InjectedState/InjectedStore). Matching is by name, since the scan never imports tool code. Follow-up to extra-org#156 review; step toward extra-org#114. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
Asaf-prog
self-requested a review
November 2, 2026 15:58
Asaf-prog
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #156 for issue #114 to ensure that runtime tool parameters do not send warnings when a description isn't passed. A new check
_is_runtime_injectedis added to skip parameters LangChain fills in at runtime but never sends to the model.