Stop the dark-header logo filter from blanking custom logos - #261
Open
amjadr360 wants to merge 1 commit into
Open
Stop the dark-header logo filter from blanking custom logos#261amjadr360 wants to merge 1 commit into
amjadr360 wants to merge 1 commit into
Conversation
Contributor
|
@KevinBatdorf this is working as expected (test here) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some site logos were showing up as a blank white block. Two of the newer headers sit on top of the hero image and turn the logo white so it can be seen against the dark photo. That works for a simple one-colour logo, but a logo that carries its own background just becomes a solid white rectangle.
Now only the logos we generate get the white treatment. Anything the site owner uploaded keeps its own colours and sits on a light rounded backing so it still reads against the dark header.
Both of those headers also stop showing the site name next to the logo. An uploaded logo nearly always has the name in it already, so it was appearing twice.