Repository navigation
Conversation
The Map orders each layer by where a screen's parents sit, and broke ties by screen id. Screens a hub leads to (the tabs of a tab bar) all tie, so their order followed their content-hash ids and the next layer's edges crossed. Ties now go to the screen the run reached first, then to the id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Map lays out each layer by where a screen's parents sit (
flatPositions), and breaks ties by screen id. Screens that a hub leads to all share that hub as their parent, so they always tie. A tab bar is the common case: a replay that opens each tab from the first tab and goes back. Their order then follows their content-hash ids, which look random. The screens one tap further are placed next to their parents, so in the next layer the edges slant across each other, and the tabs are never in tab-bar order.Ties now go to the screen the run reached first (
screen.firstSeenAt), then to the id as before. For an exploration or a--replayrun, that is the order the screens were reached in. With a plan, that means the author can choose the order.Screenshots
An anonymised copy of a real
explore:binary --replayreport: generic titles, placeholder screenshots. After onboarding (Step 1–8), "Tab 1" leads to each other tab and back, and three tabs have a detail screen.No change to colour or the phone layout.
Code examples
No change to usage.
Try it
Open any report whose start or hub screen leads to several screens, such as a replay that visits each tab from the first one. Those screens now stack in the order the run reached them.
Testing
npm run typecheck,npx eslinton the changed file,npm run build.npm run test:node: 1709 of 1713 pass. The 3 failures also fail onmainon this machine and come from its environment: the doctor temporary-directory check, the executable-bit check after a build, and the help output.node dist/cli.js view --dir <report>againstnpx @expo/explore@0.23.0 view, Map view.