Skip to content

integration: phone passkeys + AppLoad auth app (from #2, rebased) - #4

Draft
exp78 wants to merge 3 commits into
masterfrom
integration/passkey
Draft

exp78 wants to merge 3 commits into
masterfrom
integration/passkey

Conversation

@exp78

@exp78 exp78 commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Rebase of #2 (ericlewis: native phone passkeys + AppLoad auth demo) onto current master, plus a review follow-up commit.

  • Original commit kept intact (author credit preserved): e998335
  • Review fixes in 7b81b04: BT stack teardown on restore, dev-deps, vendored patch tests wired, LD_LIBRARY_PATH pinning, npm ci --ignore-scripts, .gitattributes -text, Python 3.9 compat, frame-pacing rider documented, ubuntu digest pin
  • Device PASS claim is contributor-reported; maintainer verification pending

Credit to @ericlewis for the original work in #2.

ericlewis and others added 3 commits October 8, 2026 20:37
- platform guard: a helper that created the Bluetooth stack (modprobe
  btnxpuart + bluetooth.service) now also stops the service and unloads
  the module on the bounded restore path, in reverse creation order;
  state-machine tests cover ordering, failure and stall bounds.
- helper Cargo.toml: serde_cbor_2/serde_bytes are contract-test only;
  moved to dev-dependencies (src/ grep clean, --locked unchanged).
- build-sdk.sh: also run the vendored patch's private_probe_order_tests
  against the staged libwebauthn lock; clear skip before prepare.py.
- auth entry: pin LD_LIBRARY_PATH to the installation-derived runtime
  lib dir instead of forwarding an inherited value (LD_PRELOAD stays
  unset); the launcher exports the identical path from rmweb-env.sh,
  and unsetting is not viable because the staged runtime resolves its
  transitive libraries through it. Entry fixture asserts the pinning.
- tests workflow: npm ci --ignore-scripts for passkey-acceptance.
- .gitattributes: *.patch -text so CRLF checkouts cannot break the
  recorded patch sha256 receipts.
- prepare-app-headers: replace the PEP 701 nested-quote f-string; the
  script parses with the Python 3.9 grammar again.
- patches/README: document the bundled WPEViewHeadless frame-pacing
  component (8 fps passive, 30 Hz post-input burst, presentation-paced
  reference) and that it is rmweb's production render path.
- README/docs: on-device verifier PASS results are marked as
  contributor-reported with maintainer verification pending.
- Dockerfile.app-only-sdk-3.28: pin ubuntu:24.04 by multi-arch index
  digest.
- launchers: file-level shellcheck SC2015 for the intentional
  'cond && cond || fail' assertion idiom (unbreaks the lint gate).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Ubuntu removed the superseded 2.80.0-6ubuntu3.8 builds from the pool,
breaking the pinned engine-build downloads (the exact bit-rot flagged in
review). New URLs, sizes and sha256 verified against ports.ubuntu.com.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants