CMake: Make libint2 Fortran interface explicit - #423
Open
Growl1234 wants to merge 4 commits into
Open
Conversation
Follow-up to the Libint2 Fortran interface work in this branch: * decide PIC for the libint_f objects from L2_BUILD_SHARED_LIBS rather than BUILD_SHARED_LIBS, matching int-obj. With LIBINT2_BUILD_SHARED_AND_STATIC_LIBS=ON and BUILD_SHARED_LIBS=OFF the now-installed libint2_f.a was built without -fPIC while interface-linking the shared libint2. * install the generated Fortran headers (fortran_incldefs.h, libint2_types_f.h) into <includedir>/libint2/fortran and add that directory to the target's INSTALL_INTERFACE. fortran_example.F90, the canonical consumer example, #includes fortran_incldefs.h, so downstream users of the installed target could not compile. * name the public consumption target Libint2::fortran, as INSTALL.md already advertised, aliased to int_f in the build tree and in libint2-config.cmake, the same way Libint2::int2 and Libint2::cxx are handled. int_f remains the exported internal target. This also makes a namespaced name available to add_subdirectory/FetchContent users. * rename CMAKE_INSTALL_Fortran_MODULES to LIBINT2_INSTALL_FMODDIR and make it a cache entry, out of the reserved CMAKE_ namespace. It is declared the way GNUInstallDirs declares its own path variables, because a plain set(... CACHE PATH) rewrites a relative -D value into an absolute path below the build directory. * forward LIBINT2_INSTALL_FMODDIR to the library ExternalProject and add it to the staging-area install directories, so the packaging use case works in the one-shot generator + library build. * resolve the fortran component from the imported target instead of the configure-time option, deferring check_required_components() until after the targets file is included, and move its doc line out of the ordering-code table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libint2 currently installs the
libint_f.modmodule file without exporting a corresponding CMake target. As a result, downstream projects have to locate compiler-specific Fortran module directories manually.Introduce an installable
int_fwrapper library, exported asLibint2::int_f. Linking this target provides the Fortran wrapper library, the underlying Libint2 library, and the correct module include directory through its usage requirements.The Fortran module installation directory is now controlled by
CMAKE_INSTALL_Fortran_MODULES, defaulting to the existing include-directory location. Distribution packages (Fedora RPM-build) can override it at configure time, avoiding post-install relocation oflibint_f.mod.This allows downstream projects to consume the Fortran interface through the exported package metadata rather than searching for
libint_f.modthemselves.