Skip to content

Feature/add hrwsi notebook #1 - #133

Open
HRSIteam wants to merge 4 commits into
eu-cdse:mainfrom
HRSIteam:feature/add_hrwsi_notebook
Open

HRSIteam wants to merge 4 commits into
eu-cdse:mainfrom
HRSIteam:feature/add_hrwsi_notebook

Conversation

@HRSIteam

@HRSIteam HRSIteam commented Nov 2, 2026

Copy link
Copy Markdown

Description:
finalisation of the HR-WSI notebook in the "geo" kernel folder.
Shapefile replaced with geojson.

@mariiaShevchuk mariiaShevchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and for addressing Maxim's comments, the GeoJSON makes it much easier to use! A few fixes before merging:

  • Part B, step 1: the print statement uses watershed_geojson, which isn't defined, so this raises a NameError on a fresh run. Could you change it to {basin_geojson}?
  • Part A, step 4, single product: DOWNLOAD_URL_TEMPLATE + productID should be DOWNLOAD_URL_TEMPLATE.format(productID).
  • the "Python linting" check fails because the notebook isn't formatted with black. Running pip install "black[jupyter]==23.3.0" and then black geo/ should fix it.
  • the # in the filenames breaks plain links, could you please remove it from both filenames and update the GeoJSON path in the notebook (Part B, step 1)?

You can ignore the failing test-samples check. It can't run from a fork.

Comment thread geo/.tests Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants