Repository navigation
Conversation
mariiaShevchuk
requested changes
Nov 3, 2026
mariiaShevchuk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR and for addressing Maxim's comments, the GeoJSON makes it much easier to use! A few fixes before merging:
- Part B, step 1: the print statement uses
watershed_geojson, which isn't defined, so this raises a NameError on a fresh run. Could you change it to{basin_geojson}? - Part A, step 4, single product:
DOWNLOAD_URL_TEMPLATE + productIDshould beDOWNLOAD_URL_TEMPLATE.format(productID). - the "Python linting" check fails because the notebook isn't formatted with black. Running
pip install "black[jupyter]==23.3.0"and thenblack geo/should fix it. - the
#in the filenames breaks plain links, could you please remove it from both filenames and update the GeoJSON path in the notebook (Part B, step 1)?
You can ignore the failing test-samples check. It can't run from a fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
finalisation of the HR-WSI notebook in the "geo" kernel folder.
Shapefile replaced with geojson.