Skip to content

fix: avoid double-counting tax in Amazon splits - #101

Merged
eshaffer321 merged 1 commit into
mainfrom
codex/amazon-tax-allocation
Oct 3, 2026
Merged

eshaffer321 merged 1 commit into
mainfrom
codex/amazon-tax-allocation

Conversation

@eshaffer321

Copy link
Copy Markdown
Owner

Summary

  • Prevent the Amazon splitter from adding order-level tax on top of charge-allocated item prices.
  • Add a regression using the reported multi-category order values and document the proportional allocation limitation.

Verification

  • go test -race ./...
  • make pre-commit-local
  • Amazon dry run was attempted but could not fetch orders because the local erick profile is missing essential cookies.

Related issue: #100

@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.48%. Comparing base (0d7a6aa) to head (a2b7468).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   65.37%   65.48%   +0.10%     
==========================================
  Files          51       51              
  Lines        7036     7038       +2     
==========================================
+ Hits         4600     4609       +9     
+ Misses       2094     2087       -7     
  Partials      342      342              
Flag Coverage Δ
unittests 65.48% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/application/sync/handlers/amazon.go 73.40% <100.00%> (+2.68%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshaffer321
eshaffer321 merged commit b242e5e into main Oct 3, 2026
14 checks passed
@eshaffer321
eshaffer321 deleted the codex/amazon-tax-allocation branch October 3, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant