🧹 refactor: remove repetitive parameter passing in IconAsyncButton - #15
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: esenmx <43244505+esenmx@users.noreply.github.com>
Co-authored-by: esenmx <43244505+esenmx@users.noreply.github.com>
Replace the variants smoke test, which only asserted that an IconButton rendered, with one that checks the Material background and outline side per constructor. A swapped tear-off arm in _buildIconButton now fails the suite instead of passing silently.
2bba5e4 to
87072fa
Compare
🎯 What:
Refactored
IconAsyncButtonto eliminate repetitive parameter passing acrossIconButtonconstructor variants (standard,filled,filledTonal,outlined). Introduced a private_buildIconButtonmethod using constructor tear-offs.💡 Why:
Reduces boilerplate code and repetition in
build(), improving maintainability and readability without altering behavior or API.✅ Verification:
Passed
flutter analyzeand all package tests viaflutter test.✨ Result:
Cleaner and more maintainable
IconAsyncButtonimplementation.PR created automatically by Jules for task 4206677125264470908 started by @esenmx