Skip to content

🧹 refactor: remove repetitive parameter passing in IconAsyncButton - #15

Merged
esenmx merged 3 commits into
mainfrom
refactor-icon-async-button-duplication-4206677125264470908
Aug 23, 2026
Merged

🧹 refactor: remove repetitive parameter passing in IconAsyncButton#15
esenmx merged 3 commits into
mainfrom
refactor-icon-async-button-duplication-4206677125264470908

Conversation

@esenmx

@esenmx esenmx commented Aug 22, 2026

Copy link
Copy Markdown
Owner

🎯 What:
Refactored IconAsyncButton to eliminate repetitive parameter passing across IconButton constructor variants (standard, filled, filledTonal, outlined). Introduced a private _buildIconButton method using constructor tear-offs.

💡 Why:
Reduces boilerplate code and repetition in build(), improving maintainability and readability without altering behavior or API.

✅ Verification:
Passed flutter analyze and all package tests via flutter test.

✨ Result:
Cleaner and more maintainable IconAsyncButton implementation.


PR created automatically by Jules for task 4206677125264470908 started by @esenmx

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 3 commits August 23, 2026 19:01
Co-authored-by: esenmx <43244505+esenmx@users.noreply.github.com>
Co-authored-by: esenmx <43244505+esenmx@users.noreply.github.com>
Replace the variants smoke test, which only asserted that an IconButton
rendered, with one that checks the Material background and outline side
per constructor. A swapped tear-off arm in _buildIconButton now fails
the suite instead of passing silently.
@esenmx
esenmx force-pushed the refactor-icon-async-button-duplication-4206677125264470908 branch from 2bba5e4 to 87072fa Compare August 23, 2026 16:03
@esenmx
esenmx merged commit 4c2cc49 into main Aug 23, 2026
6 checks passed
@esenmx
esenmx deleted the refactor-icon-async-button-duplication-4206677125264470908 branch August 23, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant