Repository navigation
Close the Critter Stack audit: accept the remaining Tier B items with reasons - #12
Merged
Merged
Conversation
… reasons Doc-only. Marks docs/critter-stack-audit.md closed after PRs #8 to #11 and records why B6, B7, B8, B10, and B11 stay as they are: - B6 inline clock: deliberate before/after asymmetry exhibit. - B7 two round trips in PlaceOrder.LoadAsync: slide readability at demo scale. - B8 explicit seeding over IInitialData: saves one line, fixture still calls it. - B10 unconditional RuntimeCompilation reference: Development-only repo, csproj comment pre-answers the production question. - B11 baker-task polling loop: the skill's own escape hatch for a suite shared with a non-Wolverine twin. BakerTaskItem flagged for its Item suffix, left alone. Audit doc added to the solution items alongside the other docs. Build-log closing entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc-only. Closes
docs/critter-stack-audit.mdafter PRs #8 to #11 shipped both Tier A items and five Tier B items. Records why the remaining six Tier B items stay as they are, adds the audit doc to the solution items alongside the other docs, and adds the build-log closing entry. No code, no count changes.Accepted as they stand
DateTimeOffset.UtcNow. The before twin's injectedIDateTimeProvideragainst the after twin's inline clock is a deliberate exhibit (build log, slice 002); the seed windows make time control unnecessary.PlaceOrder.LoadAsync. A batch query would save one round trip at demo scale and cost readability on the A-Frame slide.SeedData.ApplyAsyncoverIInitialData. Saves one line inProgram.cs; the test fixture would still call the seeder after wiping.WolverineFx.RuntimeCompilationreference. Development-only repo; the csproj comment already pre-answers the production question.ExecuteAndWaitAsyncagainst the before twin.Also flagged and left alone:
BakerTaskIteminGetBakerTasks.cscarries anItemsuffix; rename to a noun such asBakerTodoif it ever reaches a slide.Verification
Markdown and solution-file changes only.
git statusclean apart from these three files before commit.