Repository navigation
Audit Tier B second pass: slices move into context folders, NotifyBaker.cs rename - #10
Merged
Merged
Conversation
…er.cs B3 and B4 from docs/critter-stack-audit.md. No behaviour change. - The flat Features/ folder is gone. Slices live beside their documents in Cakes/, Coupons/, Orders/, and Ping.cs sits at the project root. Namespaces follow the folders; the LayerCake.Slices.Features namespace no longer exists, which made eleven using lines redundant (removed). - NotifyBakerHandler.cs renamed NotifyBaker.cs after the message it carries. - All moves via git mv so history follows the files. - Paths updated in README (tour tree, PublishCake pointer), the file inventory, and the three slice specs; openspec archive left as history. Unit-test usings updated. Build 0 warnings. Contract suite 54/54, unit tests 15/15. After twin 695 raw / 574 non-blank (was 706 / 585, exactly the dropped usings); before twin unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
B3 and B4 from
docs/critter-stack-audit.md. Pure reorganisation: no behaviour change, no route or contract change, per-slice file counts identical. Remaining open items after this: B2, B6, B7, B8, B10, B11.Changes
B3. Slices live in their bounded-context folders. The flat
Features/folder is gone. Each slice now sits beside the document it works on, which is the layout the JasperFx style guidance prefers over a technical grouping:Cakes/:Cake.cs,PublishCake.cs,BrowseCakes.cs,GetCake.csCoupons/:Coupon.cs,CouponValidation.cs,ValidateCoupon.csOrders/:Order.cs,BakerTask.cs,PlaceOrder.cs,NotifyBaker.cs,GetOrder.cs,GetBakerTasks.csPing.cs,SeedData.cs,Program.cs,AfterTwin.csNamespaces follow the folders (
LayerCake.Slices.Cakes/.Coupons/.Orders);LayerCake.Slices.Featuresno longer exists. That made elevenusinglines redundant and they are removed. All moves went throughgit mv, and git reports all ten as renames, so history follows the files.B4.
NotifyBakerHandler.csis nowNotifyBaker.cs, named after the message it carries, per the one-command-per-file rule.Bookkeeping. README tour tree and the
PublishCake.cspointer updated. Paths rewritten indocs/file-inventory.mdand the three slice specs.openspec/changes/archive/left as the historical record. Unit-test usings updated. Build-log entry added. Line counts: after twin 695 raw / 574 non-blank (was 706 / 585, exactly the dropped usings); before twin unchanged at 1,733 / 1,432.Verification
dotnet build: 0 warnings, 0 errorsdotnet test: contract suite 54 passed, unit tests 15 passed, 0 failedgrepforFeatures/andNotifyBakerHandler.csoutside the openspec archive and audit history: none