Slow restart file reading - #227
Draft
LudwigBoess wants to merge 4 commits into
Draft
LudwigBoess wants to merge 4 commits into
LudwigBoess wants to merge 4 commits into
Conversation
…ead of one per domain
…F so metadata is read once and broadcast
…ader thread-pool size
input.example.toml was replaced upstream by input.default.toml, generated from entity.schema.json. The adios2.read_threads, read_open_timeout_secs and read_poll_secs keys added on this branch move into the schema, and input.default.toml is regenerated from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
@LudwigBoess @Alcauchy do we need this or does #229 fix the issue already? |
Collaborator
Author
|
I think we should keep it, because it should speed things up more. But I'm fine with pushing it to 1.6.0rc to not delay the 1.5.0 release. I haven't had time to test it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ADIOS2 optimization options to reading the restart files. Similar to what's already implemented for output writing.
In my tests these changes speed up the the restart by ~300x