feat: replace grafanactl+logcli installers with unified gcx installer - #112
Merged
Conversation
Add lib/installers/gcx.js (binary tarball install from grafana/gcx + browser-OAuth login), remove the grafanactl and logcli installers, and rewire exports, CLI menu/flags (--gcx), LLM docs, and README. Bump to 1.12.0 since 1.11.0 is already published without these changes.
fank
marked this pull request as ready for review
August 11, 2026 18:44
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the legacy grafanactl and logcli tools with the unified Grafana Cloud CLI (gcx), updating the installation scripts, documentation, and LLM configuration templates accordingly. The review feedback focuses on improving the robustness of the new gcx installer by handling HTTP download failures in curl, preventing cross-device link errors (EXDEV) when moving the downloaded binary, and wrapping configuration view executions in try-catch blocks to avoid CLI crashes.
Address PR review feedback: - curl -sLf so HTTP errors fail the download instead of writing an error page - fs.copyFileSync + chmod instead of renameSync to avoid EXDEV across filesystems - wrap 'gcx config view' in try-catch so a bad config can't crash the CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the two old Grafana installers with the new unified gcx CLI.
lib/installers/gcx.js— installs gcx fromgrafana/gcxGitHub release tarballs (gcx_<v>_<os>_<arch>.tar.gz) to~/.local/bin(no Go toolchain needed), plus browser-OAuth login/config. Handles gcx's JSONcurrent-contextoutput in agent mode.grafanactl.jsandlogcli.js.lib/index.js,lib/installers/index.js), CLI (bin/cli.js: menu entry,--gcxflag, 12→11 steps), agent docs (lib/llm/index.js), andREADME.md.Verification
npm run lint✅ ·npm run check-format✅isGcxInstalled / isGcxConfigured / getCurrentContextagainst local gcxgcx logs|metrics|traces|dashboards)Follow-up
@enthus-appdev/llm-cli-setup@1.12.0so consumers (environment-setup) can install the gcx installer.