Repository navigation
NXT-20662: Update package dependencies to fix security vulnerabilities - #267
Conversation
|
The title and description say this fixes security vulnerabilities, but no advisory or affected package is named, and Resolution is empty. The diff bumps the agate, limestone, and ui samples to Enact ^5.6.0, Agate ^3.3.0, Limestone ^1.12.0, React ^19.3.0, and Redux Toolkit ^2.13.0. Moonstone and sandstone are unchanged and still depend on Enact 4 and React 18. Please say whether that is intentional, and list the bumps that did land. The changelog checkbox is unchecked. CHANGELOG.md already has generic unreleased lines, and this PR also moves react-router from 7 to 8 and @enact/ui from 4.9.4 to ^5.6.0. Please add those. |
| "react-router": "^7.13.1" | ||
| "react": "^19.3.0", | ||
| "react-dom": "^19.3.0", | ||
| "react-router": "^8.4.0" |
There was a problem hiding this comment.
This is a major bump from ^7.13.1. The sample imports HashRouter, Routes, Route, and useNavigate. React Router 8 also requires Node >= 22.22.0. Please confirm the sandbox still routes, and mention this major in the description. The other samples were already on ^8.1.0 and only move to ^8.4.0.
| "@enact/i18n": "^5.6.0", | ||
| "@enact/limestone": "^1.12.0", | ||
| "@enact/spotlight": "^5.6.0", | ||
| "@enact/ui": "^5.6.0", |
There was a problem hiding this comment.
This was pinned to 4.9.4 while the sample already depended on Enact 5 and Limestone 1.x. Moving it to ^5.6.0 matches the rest of the sample, and the same pin is removed in limestone/pattern-virtualgridlist-api/package.json. Please call out this major in the description and confirm both samples still run.
Enact-DCO-1.0-Signed-off-by: Alexandru Morariu alexandru.morariu@lgepartner.com
Checklist
Issue Resolved / Feature Added
Update package dependencies to fix security vulnerabilities
Resolution
Bigger jumps worth reviewing
Additional Considerations
Moonstone and Sandstone are unchanged as support for those libraries was interrupted.
Links
NXT-20662
Comments