Repository navigation
NXT-20662: Update package dependencies to fix security vulnerabilities - #276
Conversation
|
The title and description say this fixes security vulnerabilities, but no advisory or affected package is named, and Resolution is empty. The diff is a dependency bump plus a CI branch change. Please list the real changes: React and ReactDOM to ^19.3.0, react-live to ^5.0.0 for the agate, core, and limestone runners, linkinator to ^8.1.0, @enact/limestone to ^1.12.0, and the CI clone of enactjs/cli moving from release/7.2.x.develop to develop. Sandstone stays on react-live ^4.1.8 and moonstone on ~4.1.7. Please say whether that is intentional. Please also add the Enact-DCO sign-off in Comments. |
|
|
||
| ## [unreleased] | ||
|
|
||
| - Updated minor dependencies versions to the latest. |
There was a problem hiding this comment.
This entry does not match the diff. linkinator moves from 6 to 8 and react-live moves from 4 to 5, and the CI workflow now clones cli develop. Please name those changes here.
| "eslint": "^9.39.5", | ||
| "eslint-config-enact": "^5.1.3", | ||
| "linkinator": "^6.1.2", | ||
| "linkinator": "^8.1.0", |
There was a problem hiding this comment.
This is a two-major jump from ^6.1.2 and it is not mentioned in the description. npm run check-links still calls linkinator ./dist --recurse --verbosity error. Please confirm those flags still work on linkinator 8.
There was a problem hiding this comment.
I ran the command on linkinator 8.1.0 here, and npm run check-links (linkinator ./dist --recurse --verbosity error) works the same as on 6.1.2.
Enact-DCO-1.0-Signed-off-by: Alexandru Morariu alexandru.morariu@lgepartner.com
Checklist
Issue Resolved / Feature Added
Update package dependencies to fix security vulnerabilities
Resolution
Additional Considerations
Updated major versions:
react-live: ^4.1.8 --> ^5.0.0 no breaking changes (https://github.com/FormidableLabs/react-live/releases/tag/react-live%405.0.0)
linkinator: ^6.1.2 --> ^8.1.0 no breaking changes (https://github.com/JustinBeckwith/linkinator/releases?page=1)
Moonstone and Sandstone are unchanged as support for those libraries was interrupted.
I changed the cli version to develop.
Links
NXT-20662
Comments