Repository navigation
NXT-20807: Updated cli to support typescript 6 and 7 - #404
Open
daniel-stoian-lgp wants to merge 1 commit into
Open
daniel-stoian-lgp wants to merge 1 commit into
daniel-stoian-lgp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Apps that upgrade to
typescript@7fail to build withenact pack/enact serve:There are two causes:
mainfield, onlyexports. Theresolvepackage used to find the app'stypescriptdoesn't readexports, so lookup fails.require('typescript').createProgramisundefined).fork-ts-checker-webpack-pluginneeds that API.Resolution
resolveLegacyTypeScript()finds the app'stypescriptwith Node's own resolver, soexportsworks. It turns onForkTsCheckerWebpackPluginonly if the package hascreateProgram. Otherwise it warns and skips type checking, so the build still succeeds. Removes the now-unusedresolveimport.import('chalk')/import('strip-ansi')chain so a failed build exits with code 1, even if the failure happens beforechalkloads.typescriptpeer range goes from^5.4.0to^5.4.0 || ^6.0.0 || ^7.0.2. TS 6 still has the compiler API and works with the checker.Effect on apps:
5.x / 6.x - Unchanged:
fork-ts-checker-webpack-pluginruns7.x - Skipped, with a warning
none / no
tsconfig.json- Unchanged: no checkingAdditional Considerations
Side effects / open questions:
tsc --noEmitstep. A follow-up could run the nativetscinside the build.Links
NXT-20807
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)