feat(annotation): delete selected items with Backspace/Delete - #655
Open
MathiasWP wants to merge 3 commits into
Open
feat(annotation): delete selected items with Backspace/Delete#655MathiasWP wants to merge 3 commits into
MathiasWP wants to merge 3 commits into
Conversation
Add deleteSelectedAnnotations() to the annotation capability/scope and bind Backspace and Delete in the default viewer and examples to delete the current selection - annotations, shapes, stamps, signatures, form widgets, or a selected pending redaction. Deletes the full multi-selection, is disabled when nothing is selected, and ignores key presses while typing in inputs or the free-text editor.
|
@MathiasWP is attempting to deploy a commit to the OpenBook Team on Vercel. A member of the Team first needs to authorize it. |
main restructured the repo since this branch was cut: the annotation plugin was rewritten (packages/plugin-annotation -> packages/plugin/annotation, class plugin -> capability), the snippet viewer became packages/viewer/chrome, and the *-tailwind examples were removed. Every file this branch touched is gone upstream, so the conflicts are resolved by taking main's deletions and porting the feature onto the new architecture. The port is much smaller than the original change because main already has most of it: `annotation:delete` deletes the whole selection (and cascades widgets through the form plane), pending redactions are ordinary annotations with subtype 'redact' so they share the annotation selection, and useCommandShortcuts already ignores strokes from editable targets. What was missing: - Bind Backspace/Delete to `annotation:delete` in the chrome command config. - Only preventDefault in useCommandShortcuts when the matched command is visible and enabled, so Backspace keeps its native behavior when there is nothing to delete. Replaces the old changeset with one naming the packages that now exist.
A local verification build regenerated this pin; it is not part of this branch's change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Press Backspace or Delete to delete the current selection — annotations, shapes, stamps, signatures and form widgets, or a selected pending redaction.
Adds a
deleteSelectedAnnotations()method to the annotation capability/scope and binds the keys in the default viewer and examples. Deletes the full multi-selection, is a no-op when nothing is selected (keys keep native behaviour), and ignores key presses while typing in inputs or the free-text editor.