feat: Add dark-mode compatibility for note color themes on non-elementary OS environments - #150
Closed
codemedic wants to merge 3 commits into
Closed
feat: Add dark-mode compatibility for note color themes on non-elementary OS environments#150codemedic wants to merge 3 commits into
codemedic wants to merge 3 commits into
Conversation
codemedic
marked this pull request as ready for review
August 18, 2026 00:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements dark-mode support for Jorts note themes in environments lacking the native elementary OS stylesheet (such as standard GNOME/Adwaita setups via Flathub). Also fixes a window finalization memory leak.
Key Changes
Themes.css(window.themed.dark) to swap note colors (dark background, light text) and scroll view undershoots when the window has thedarkclass.StickyNoteWindow.valato dynamically toggle thedarkCSS class based on the system'sgtk-application-prefer-dark-themesetting.FORCE_DARKandFORCE_LIGHTvariables inApplication.valato override appearance preferences during development/testing.gtk_settingsnotifier with a named callback, and disconnected it in the window'sclose_requestsignal handler to prevent a reference cycle.Contributor & Agent Onboarding
We have compiled an onboarding and architectural mapping guide (
AGENTS.md) detailing Jorts' codebase structure and compilation workflows. We are happy to include this in the Pull Request if the maintainers would find it valuable.Related Issues
Closes #149
🤖 AI-Assisted Development Disclaimer
This patch was prepared, audited, and verified using Google Antigravity powered by Gemini:
code-revieweragent audited the diff and identified the global settings memory leak, which was subsequently resolved.org.flatpak.Builder) to guarantee build correctness.