Pixiewood: init Android build - #144
Conversation
|
Sorry! Broke your PR. But added some meson plumbing for easier adding of ports, in the form of target_os as meson combo option So you can easily insert android, define ANDROID, and get going without too much ugly |
887e5c6 to
5fc4dd3
Compare
|
Bumped, I'll push my build to gtk4android.geopjr.dev later. I'll also leave some notes/TODOs as review comments here. Let me know if you really want this as part of Jorts! I can do the CI and stuff, but as I mentioned on matrix, it's like gifting you a chore. E.g. Yesterday, Tuba's CI started failing because libadwaita started using a feature in glib 2.86 or something, and the github ci ubuntu-latest runner is on ubuntu 24 and doesn't have that, so I had to make it use ubuntu-26 explicitly... |
| <file compressed="true" alias="Application.css">Application.css</file> | ||
| <file compressed="true" alias="Themes.css">Themes.css</file> | ||
|
|
||
| <file preprocess="xml-stripblanks">icons/scalable/actions/edit-delete-symbolic.svg</file> |
There was a problem hiding this comment.
maybe these icons should be conditionally bundled only for android, like I do in Tuba
There was a problem hiding this comment.
maybe some script magic to retrieve icons from the host system into the builddir and loop-sed them into gresource like this? So we can avoid unrelated turbo cluttering the world
There was a problem hiding this comment.
could just git clone the elementary icons repo in the ci or build script and move them to the folder + add them to this file
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <component type="desktop-application"> | |||
| <component type="desktop-application" xmlns="https://specifications.freedesktop.org/metainfo/1.0"> | |||
There was a problem hiding this comment.
turns out that this does in fact cause issues. xgettext won't be able to use the appstream rules and will start marking everything for translation, has to be conditionally added
There was a problem hiding this comment.
does it breaks standard builds? If standard builds are just like usual with the xmlns then it may just as well be upstreamed
There was a problem hiding this comment.
it breaks the translation string extraction from this file (to fill the .pot file). I reported it to Pixiewood and Florian fixed the issue on appstream, now we're going to have to wait and see if it will get merged.
For Tuba, I just add that line with sed before running the pixiewood commands
There was a problem hiding this comment.
Yeah i think for android there will need to be a script with some bullshit-patching in
| dependencies: dependencies, | ||
| c_args: '-w', # Because of Vala we get ten thousand warnings we can do nothing about | ||
| win_subsystem: development ? 'console' : 'windows', # Show a console in windows dev builds. Seem to not bother standard builds | ||
| android_exe_type: 'application', |
There was a problem hiding this comment.
ci seems to be failing because this requires meson 1.8, has to be conditionally added if the version matches
There was a problem hiding this comment.
Am fine with bumping meson requirement, once an elementary OS based on 26.04 is out. Currently everything is held back because of 24.04
There was a problem hiding this comment.
Yeah 1.8 is too new, it's relatively straightforward to just add it conditionally (I just noticed that I never pushed that on Tuba :| )
| host_machine_system = host_machine.system() | ||
|
|
||
| if build_machine_system == 'windows' | ||
| if host_machine_system == 'windows' |
There was a problem hiding this comment.
no clue if it matters, the only guess I have is that it might be true if you are building for android on windows, if it uses the build_machine one
There was a problem hiding this comment.
i dont fuck with cross-compiling, so you da boss here
2 participants
No description provided.