Skip to content

docs: correct TruffleData lockfile pin version in integration guide - #209

Closed
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-correct-truffledata-lockfile-pin-version-in-i-6a53a3
Closed

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-correct-truffledata-lockfile-pin-version-in-i-6a53a3

Conversation

@detail-app

@detail-app detail-app Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

The "Published TruffleData integration" section in docs/INTEGRATION.md stated the lockfile pins truffledata-core, truffledata-protobuf and truffledata-jdbc at 0.12.0, and that the protobuf adapter depends on truffledata-protobuf-runtime at 0.12.0. After TruffleData was bumped to 0.14.0 (matching maven_install.json and the README usage example updated for the 0.13.0 release), these references described the "current source tree" with the wrong version.

A developer reading the integration guide would expect to resolve TruffleData 0.12.0 artifacts from maven.elide.dev, contradicting the actual lockfile pins (0.14.0) and the README example.

Introduced by commit a31f1c5 (Sam Gammon (@sgammon), #161)


Doc Drift PRs can be configured here.

@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Nov 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 21 untouched benchmarks


Comparing detail/fix-docs/docs-correct-truffledata-lockfile-pin-version-in-i-6a53a3 (6faf4be) with main (a31f1c5)

Open in CodSpeed

@detail-app

detail-app Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Closing because the intended fix is already present on main: docs/INTEGRATION.md now pins dev.elide:truffledata-core/-protobuf/-jdbc at 0.15.0 with Elide GraalVM 25.5.5-elide.31 (matching MODULE.bazel:19-22 and MODULE.bazel:12-17), introduced by PR #210 / commit a60a1ba (feat(deps): adopt TruffleData 0.15.0 and Elide GraalVM .31). The 0.14.0 version this PR proposed is now superseded, and rebasing would just reproduce the already-landed content.

@detail-app detail-app Bot closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant