Repository navigation
docs: correct TruffleData lockfile pin version in integration guide - #209
Closed
detail-app[bot] wants to merge 1 commit into
Closed
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
detail-app
Bot
requested review from
Dario Valdespino (darvld) and
Sam Gammon (sgammon)
as code owners
November 17, 2026 16:33
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Closing because the intended fix is already present on main: docs/INTEGRATION.md now pins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Published TruffleData integration" section in docs/INTEGRATION.md stated the lockfile pins truffledata-core, truffledata-protobuf and truffledata-jdbc at 0.12.0, and that the protobuf adapter depends on truffledata-protobuf-runtime at 0.12.0. After TruffleData was bumped to 0.14.0 (matching maven_install.json and the README usage example updated for the 0.13.0 release), these references described the "current source tree" with the wrong version.
A developer reading the integration guide would expect to resolve TruffleData 0.12.0 artifacts from maven.elide.dev, contradicting the actual lockfile pins (0.14.0) and the README example.
Introduced by commit a31f1c5 (Sam Gammon (@sgammon), #161)
Doc Drift PRs can be configured here.