Repository navigation
Isolate runtime state for independent Truffle engines - #8
Open
Sam Gammon (sgammon) wants to merge 1 commit into
Open
Sam Gammon (sgammon) wants to merge 1 commit into
Sam Gammon (sgammon) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pkl standard-library modules and several builtin ASTs currently live in process-wide singletons. Using them across independent Truffle engines can fail with invalid AST sharing. Move that state into the owning language instance so each engine can initialize and reuse its own standard library.
This also isolates bootstrap inputs and thread-local type-checking state, creates factory members per language instance, and removes cached prototypes and type nodes that cross engine boundaries. The legacy Evaluator continues to reuse its internal engine.
Stack: 1 of 2, based on
main. Dependent PR #9 adds the public polyglot entry points and independent-engine integration tests.Validation: full existing
pkl-coretest suite and Javadoc generation. Native-image builds and performance benchmarks have not been run.