Repository navigation
fix(ui): give buttons a hard edge - #27
Open
Sam Gammon (sgammon) wants to merge 1 commit into
Open
Sam Gammon (sgammon) wants to merge 1 commit into
Sam Gammon (sgammon) wants to merge 1 commit into
Conversation
The gradient and primary rim sat between the face and the page in tone, with a blurred glow under it, so the edge read as soft, most of all on a dark page. The rim now contrasts with both the face and the page: deeper than the face in the light theme, lighter than it in the dark theme. --button-shadow is one unblurred pixel of shade in place of the glow. The outline button's rim goes from 25% to 40% of the foreground and loses its shadow. Contrast tests pass (357). The ui package's tests were not run locally; this checkout has no dependencies installed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Buttons read as soft, or blurred, at their edges. Magnified, the cause is two things:
--button-shadowwas a blurred glow (up to 10px) around the button.The outline button had the same character: a rim at 25% of the foreground, with
shadow-xsunder it.Change
--button-border-backgroundand its hover value contrast with both the face and the page: deeper than the face in the light theme (68% and 60%, from 82% and 76%), and lighter than the face in the dark theme (mixed with white).--button-shadowand--button-shadow-hoverare one unblurred pixel of shade.outline: rim at 40% of the foreground, no shadow; its hover rim goes from 60% to 70%.No API change.
changelogandghostare untouched.Checks
packages/tokens: contrast tests pass (357).packages/uitests and lint were not run locally (the checkout had no dependencies installed); CI covers them.🤖 Generated with Claude Code