This repository was archived by the owner on Nov 2, 2026. It is now read-only.
Repository navigation
fix: keep the card working while the switch is not ready - #5
Merged
Merged
Conversation
- Keep the last answer when a read fails, retry after 15 seconds, read again when the switch's entities come back; ignore answers for a switch the card no longer shows. - Explain an integration that is too old or a device that is not a loaded switch. - A link without a known speed is blue, not green; PoE states in the user's language. - PoE total is a button and hidden without values; port names shortened; screen readers get the port description with commas. - One set of words for card and dialog; the card is listed once in the picker. - Card height from its rows; loader tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
HACS installs a plugin from its latest release. Without one the check fails, and since the release workflow runs the same checks, the first release could never be made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from a neutral review before the first release (0.1.0):
src/loader.tswith tests.unknown_command), device not a loaded switch (not_found).formatEntityState(user's language); the PoE total is a button and hidden without values.Checked and left as is:
ha-formkeeps keys it does not show (layoutsurvives the dialog; frontendha-form.tsmerges...this.data), andartifact-metadata: writeis required byactions/attest(its README).Docs: the card page in ha-managed-switch is updated in eizedev/ha-managed-switch#18.
Test plan
npm run typecheck,npm test(21 tests),npm run buildpassCHANGELOG.md, README and the card page in ha-managed-switch updated🤖 Generated with Claude Code