[ehoeve786]

Fixes the findings from two reviews: one of an older snapshot (only the five findings main still had are kept) and one of main as of f845e68.

Port forwards

• Owner forwards work again. Since aaf770f every forward required a token line that the Port forwards screen never showed and browsers or database clients can't send, so every connection was dropped. Forwards the owner opens no longer require it; MCP agents' forwards still do.
• Forwards end when MCP is turned off. Pooled MCP sessions, and the forwards on them, now close when the server stops (including the idle timer and screen-off option), an agent token is revoked, or Claude is disconnected. They also close within a minute of MCP read access being turned off for that host, or the host being deleted. Pooled sessions are shared, so revoking one client also closes other clients' forwards.
• Forwards can't stall the app. The accept loop and relays run on their own threads instead of the shared IO pool, which about 64 forwards could exhaust. MCP may keep at most 8 per connection. ssh.close_forward now needs read access, the same as opening one.

OAuth

• Refresh retry window. A retry inside the 30-second window used to leave two live token pairs, so a stolen refresh token replayed in that window was never detected. Now only the retry's pair stays live, and the other copy's next refresh is treated as theft and revokes the login.
• Pairing lockout. The 5-wrong-tries lockout, which anyone with the public URL could trip to cancel the owner's code, is replaced by a 10/minute rate limit on POST /authorize. That allows about 100 guesses per code against 31^8 codes.

Other fixes

• Snippet quoting. Values are now escaped for where they sit. Inside '…' plain single-quoting left the value unquoted, and inside "…" it left $(…) live. Only exec-scoped agents can run snippets, so there was no privilege gain, but the tool's "quoted, not interpreted" promise was false.
• Host rename. Renaming replaces the old entry instead of leaving a copy with its trusted key and MCP permissions. A name already in use is refused. Scheduled jobs follow the new name.
• Trust new key. It now updates the latest saved record, so an edit made since the connect started (such as an MCP permission turned off) is kept.
• Upload resume. The partial file is also matched by the source's modified time, so an edited file starts over instead of resuming onto old bytes.
• Plugin commands stop after 1 hour.
• Terminal writer thread exits when idle instead of leaking one per reconnect.
• Folder upload removes its partial file on failure or cancel.

Behaviour changes

• Renaming a host breaks Tasker/MacroDroid actions that use the old name; they need to be edited and saved again. Scheduled jobs are updated automatically.
• A plugin command running longer than 1 hour is stopped and reported as failed.
• An owner forward can be used by any app on the phone, as with standard SSH clients.

Testing

• gradle testDebugUnitTest: 114 tests, no failures. New tests cover the refresh retry, snippet quoting inside single and double quotes and after an escaped quote, and wrong pairing guesses.
• gradle :app:assembleDebug succeeds.
• Not run locally: emulator tests and the signed release build (CI runs both). None of the fixes were tried in the running app.

🤖 Generated with Claude Code