fix(backspace): unexpected caret jumps on backspace - #192
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a caret-jump bug in Editor.js tables by preventing Editor.js core from receiving Backspace keydown events originating inside the table, keeping cursor behavior stable when deleting content (notably trailing spaces) within a cell.
Changes:
- Stop
Backspacekeydown events from bubbling out of the table element (similar to existingTabhandling). - Update the inline documentation to reflect the expanded keydown interception.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue when caret unexpectedly jumps to another row on backspace press at the end of the cell.
We prevent Editor.js core backspace handling.
Closes #2952
Related #174